jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-731699320
Hi @rmannibucau ,
Since I have no write access for this repo，I was wondering if you could
merge this PR or somebody else would do?
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-729328053
[MSHADE-378] Shade plugin changes the compression level of nested jar
entries, see more at this [jira ticket
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-728792839
Hi @rmannibucau ,
A test is added for this PR to verify that shade plugin wouldn't change the
compression level of nested jar. By the way, ZipHeaderPeekInputStream
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-705325012
Hi @rmannibucau ,
thanks for your review and comment，I will add a test for this case. As for
using PushbackInputStream, it seems like a better
idea and I will
jenrryyou commented on pull request #73:
URL: https://github.com/apache/maven-shade-plugin/pull/73#issuecomment-705325012
Hi @rmannibucau ,
thanks for your review and comment，I will add a test for this case. As for
using PushbackInputStream, it seems like a better
idea and I will
