[GitHub] [maven-shade-plugin] kriegaex edited a comment on pull request #100: [MSHADE-396] Improve SourceContent Shading

2021-07-12 Thread GitBox
kriegaex edited a comment on pull request #100: URL: https://github.com/apache/maven-shade-plugin/pull/100#issuecomment-878093571 I re-implemented your PR in a somewhat different way, also covering additional test cases which would otherwise have failed for my usual test project AspectJ.

[GitHub] [maven-shade-plugin] kriegaex edited a comment on pull request #100: [MSHADE-396] Improve SourceContent Shading

2021-07-07 Thread GitBox
kriegaex edited a comment on pull request #100: URL: https://github.com/apache/maven-shade-plugin/pull/100#issuecomment-876058443 Sorry for the late feedback. I just checked out this PR and ran it against my shading configuration in AspectJ, then diffed the shaded source archives before