[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-884271031 Let's keep this and the ticket open until we are able to fix this in Maven. This PR will remind us that something is broken in Maven. As @rfscholte said, This isn't

[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-873662333 My personal opinion: A broken cache should be removed or improved. @rfscholte Remove or try to solve. -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-873623496 1. The fix from you is incomplete, at the end we likely need to revert d3ace78602405079d6416a63c13216568ba97995 (MNG-6638) 2. Can you verify that adding the id also

[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-873101680 I have now reintroduced the hack comment in master and 3.8.x. Will process your message later. -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-870457060 I would reintroduce the comment about the hack because it remains what it is: a hack! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-870457060 I would reintroduce the comment about the hack because it remains what it is: a hack! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-869070838 A friendly reminder, I want to start the release by mid of next week. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-864394719 So I reviewed this PR, the JIRA issue as well as MSHARE-206 and MNG-5899 and I see a few issues here: * The description on the JIRA issue is wrong * From my PoV

[GitHub] [maven-shade-plugin] michael-o commented on pull request #26: [MSHADE-326] Hide shaded dependencies from the rest of the reactor build

michael-o commented on pull request #26: URL: https://github.com/apache/maven-shade-plugin/pull/26#issuecomment-863796865 Will first try to understand the problem and then get back to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log