rmannibucau commented on issue #39:
URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-618468561
Ok, will release it on github to unblock people waiting after it. That said
I'd still want to make it part of shade plugin cause it is just aligned on
transformer model, not
rmannibucau commented on issue #39:
URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-618348095
@rfscholte the plugin yes but it means it requires another configuration or
feature external to transformers. It can work but it is way less composable and
becomes more spec
rmannibucau commented on issue #39:
URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-618227793
@rfscholte it is by design since the canTransformResource impl delegates to
underlying transformers so if the underlying transformer is dynamic then it
works. Chaining does
rmannibucau commented on issue #39:
URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-618190383
@rfscholte a chain does not enable to inherit from dynamic resources so I
don't see how you aim at making it work, did I miss sthg?
rmannibucau commented on issue #39:
URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-617981739
@rfscholte hmm, what about the comment that a chain does not work compared
to a wrapper?
This is an automat
rmannibucau commented on issue #39:
URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-617666969
@rfscholte do you still think we shouldn't have this kind of transformer
wrapper or are we ok to merge?
Thi
rmannibucau commented on issue #39: [MSHADE-353] adding a generic relocation
friendly transformer
URL: https://github.com/apache/maven-shade-plugin/pull/39#issuecomment-612349935
+1 to move forward, this feature will become important with jakartaee 9
---
