[GitHub] [maven-shared-utils] rmannibucau commented on a change in pull request #54: rework directory scanner to ensure it can enforce exclusions and it uses path

2020-06-10 Thread GitBox
rmannibucau commented on a change in pull request #54: URL: https://github.com/apache/maven-shared-utils/pull/54#discussion_r438215648 ## File path: src/main/java/org/apache/maven/shared/utils/io/MatchPattern.java ## @@ -33,9 +33,7 @@ * Significantly more efficient than using

[GitHub] [maven-shared-utils] rmannibucau commented on a change in pull request #54: rework directory scanner to ensure it can enforce exclusions and it uses path

2020-06-10 Thread GitBox
rmannibucau commented on a change in pull request #54: URL: https://github.com/apache/maven-shared-utils/pull/54#discussion_r438215154 ## File path: src/test/java/org/apache/maven/shared/utils/io/conductor/EnforceExcludesOverIncludesTest.java ## @@ -0,0 +1,92 @@ +package org.a

[GitHub] [maven-shared-utils] rmannibucau commented on a change in pull request #54: rework directory scanner to ensure it can enforce exclusions and it uses path

2020-06-10 Thread GitBox
rmannibucau commented on a change in pull request #54: URL: https://github.com/apache/maven-shared-utils/pull/54#discussion_r438214900 ## File path: src/test/java/org/apache/maven/shared/utils/io/DirectoryScannerTest.java ## @@ -243,14 +243,6 @@ public void testSimpleExcludes(