[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-11 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345653699 > This is not what I understand. The specification is not concrete enough for me. That's a legit statement. However, it could take some considerable amount of time until the

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-11 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345602186 When I open the RFC it clearly says > The "Expires" field indicates the date and time[...] I think it couldn't be more clear. -- This is an automated message from the

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-11 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345601859 So, a researcher in the US gets more time. Interesting! Tbh I think only an instant makes sense to avoid this. Probably all scanners try to parse a time and "Z". It doesn't even

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-11 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345598388 > Then just drop to date only. Fully valid ISO date Spec explicitly asks for date and **TIME**. +1 for Hervés suggestion, will add later. -- This is an automated message

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-10 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345370360 I still don't believe it matters as the format string does not contain any locale-specific patterns. But if you insist, why not use the Maven properties I suggested? -- This is an

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-10 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345367729 > > @michael-o now we have this: > > > > ``` > > [INFO] --- build-helper-maven-plugin:3.3.0:timestamp-property (create-security.txt-timestamp) @ maven-site --- > >

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-10 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345362771 So you are uploading an expired file. Expires MUST be in the future! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-10 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345323411 Removing the locale now leads to a warning that the build is system dependent. Is this really wanted? I feel having warnings intentionally seems odd. This might get "fixed" by someone

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-10 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345305885 > Two issues: > * I think that using this plugin is redundant when we have this: https://maven.apache.org/guides/introduction/introduction-to-the-pom.html#special-variables > *

[GitHub] [maven-site] bmarwell commented on pull request #354: [MNGSITE-503] add .well-known/security.txt

2022-12-10 Thread GitBox
bmarwell commented on PR #354: URL: https://github.com/apache/maven-site/pull/354#issuecomment-1345254727 @michael-o now we have this: ``` [INFO] --- build-helper-maven-plugin:3.3.0:timestamp-property (create-security.txt-timestamp) @ maven-site --- [WARNING] Using platform