[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-13 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-553403097 @Micky002 I did not mention this because simply parallelism is not fixed. It is non-trivial issue which is a

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-13 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-553395200 @Col-E no problem. You are always welcome. @Col-E @jon-bell hey guys, we started the release V

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-11 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-552713741 @Col-E I fixed the issue with unique test representation in https://issues.apache.org/jira/browse/SUREFIRE-1

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-07 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-551237886 @Col-E Can we continue on making the test unique? --

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-05 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-549863884 @Seijan I guess you mean the combination of rerun and parameterized. The rerun should work with pure tests

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-03 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-549215289 The answer is in the history of the Adapter class. I don't say it was better in previous version, nothing but

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-03 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-549214210 @Col-E You should be facing strange behavior with the report. It's not strange but the implementation we nev

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-03 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-549208624 ok, let's change the methodology. Although the provider is able to run parameterized test, run `mvn test` with

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-03 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-549204514 Yes, this was my plan but we have to run the unit tests and Platform ITs because i am not sure if they would suc

[GitHub] [maven-surefire] Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns

2019-11-03 Thread GitBox
Tibor17 commented on issue #252: [SUREFIRE-1711] Support @ParameterizedTest for JUnit 5 test reruns URL: https://github.com/apache/maven-surefire/pull/252#issuecomment-549200081 @Col-E I will implement [skipAfterFailureCount in JUnit5 provider](https://issues.apache.org/jira/browse/SUR