[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2020-01-24 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-578341085 Closed in favor of #267 . This is an automated message from

[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-12-01 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-560183773 @t-8ch Do you have time for this? How are you doing with the tests?

[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-28 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559434517 @t-8ch no no, it is a class with `@BeforeAll`. Feel free to add a test in this PR. I will open new PR for the second

[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559317708 @t-8ch We have a similar issue [SUREFIRE-1688](https://issues.apache.org/jira/browse/SUREFIRE-1688) which happens when

[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559186761 no problem. Question: this change you have made includes also the name of method too? So when I see the native report in

[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559184403 Maybe keep this PR for the future motivation in SUREFIRE-1724 and open a new one PR for SUREFIRE-1727. oki?

[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559183371 @t-8ch I want to make sure that we are on the same line. Is Cucumber exotic engine for you? If it is then we can make

[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559181429 Now i know what you mean but this is the same in JUnit4. It works there. Suppose that the Runner of JUnit4 fails and the

[GitHub] [maven-surefire] Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 commented on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559179089 @t-8ch but your requirement to support all engines is covered already in