Tibor17 commented on pull request #288:
URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620186330
Here is the Jira ticket created.
https://issues.apache.org/jira/browse/SUREFIRE-1783
This is an automate
Tibor17 commented on pull request #288:
URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620182261
I forgot to ask you for a unit test. it;s easy. Just prepare the
`DefaultJavaToolChain` and call it with `Whitebox.invokeMethod`. We should
expect a path in the assertion.
Tibor17 commented on pull request #288:
URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620169605
I will merge #287 but then you have to override this PR. The first two
commits will be in conflict with one squashed commit.
--
Tibor17 commented on pull request #288:
URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620070432
You think that the java process wil not set/override the JAVA_HOME for
itself?
This is an automated messag
Tibor17 commented on pull request #288:
URL: https://github.com/apache/maven-surefire/pull/288#issuecomment-620067158
But the inheritance of the env is not done from the toolchain to the jvm.
The toolchain is used only for one purpose, to get the path of the JDK
installation on the disk, s
