[GitHub] [maven-surefire] Tibor17 commented on pull request #341: [SUREFIRE-1894] Add missing "version" attribute to report XSD

2021-03-11 Thread GitBox
Tibor17 commented on pull request #341: URL: https://github.com/apache/maven-surefire/pull/341#issuecomment-797026379 @martinmo The test verifies XML against the schema which is very suitable in this case. If the test fails without your fix and passed with it, then it is acceptable.

[GitHub] [maven-surefire] Tibor17 commented on pull request #341: [SUREFIRE-1894] Add missing "version" attribute to report XSD

2021-03-10 Thread GitBox
Tibor17 commented on pull request #341: URL: https://github.com/apache/maven-surefire/pull/341#issuecomment-796183289 Making an XML is not enough. You have to use it in a test. For more information see `Surefire597Test`.