[GitHub] [maven-surefire] Tibor17 commented on pull request #478: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true

2022-02-28 Thread GitBox
Tibor17 commented on pull request #478: URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1054539564 You added one more branching and you call `throwException`. Why? It has to end up with the only one exception - `BUILD ERROR` with no other decision making.

[GitHub] [maven-surefire] Tibor17 commented on pull request #478: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true

2022-02-28 Thread GitBox
Tibor17 commented on pull request #478: URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1054523389 Your thrown exception does not make sense, because there are two types, just notice that. If it is a `BUILD FAILURE` then it has not to fail the build because you confi