[GitHub] [maven-surefire] Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-28 Thread GitBox
Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559434517 @t-8ch no no, it is a class with `@BeforeAll`. Feel free to add a test in this PR. I will open new PR for the secon

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559184403 Maybe keep this PR for the future motivation in SUREFIRE-1724 and open a new one for SUREFIRE-1727. oki? -

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559183371 @t-8ch I want to make sure that we are on the same line. Is Cucumber exotic hierarchy for you? If it is then we

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559183371 @t-8ch I want to make sure that we are on the same line. Is Cucumber exotic hierarchy for you? If it is then we

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers

2019-11-27 Thread GitBox
Tibor17 edited a comment on issue #257: [SUREFIRE-1727] junitplatform: handle all containers URL: https://github.com/apache/maven-surefire/pull/257#issuecomment-559181429 Now i know what you mean but this is the same in JUnit4. It works there. Suppose that the Runner of JUnit4 fails a