[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-21 Thread GitBox
mthmulders commented on PR #523: URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1104849451 > @mthmulders > WDYT about using `argLine.replaceAll("\\s+", " ");` instead of what we have today? I like it, replaced the original implementation with this one. >

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-20 Thread GitBox
mthmulders commented on PR #523: URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103638849 > If the test fails with escaping characters ` `, you can try using `String.replaceAll(String, String)` with regex. > > Instead of: > > ``` > return argLine >

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-20 Thread GitBox
mthmulders commented on PR #523: URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-110363 > @mthmulders I have one more question. The developers would not be able to see the TAB because it is a white space. If the new guy would refactor it again, then this IT would not

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-20 Thread GitBox
mthmulders commented on PR #523: URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103590512 > @mthmulders What was the reason that the only Java `1.8` was working in the old IT? I am just interested. At first, I thought (due to the original report in JIRA) that the

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-19 Thread GitBox
mthmulders commented on PR #523: URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103074651 > Did you use JDK1.8 on your PC when you tested the IT? > Look at the GH CI results. All JDKs fail except 1.8. > Is this the reason? I'll soon push an update to an exis

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-18 Thread GitBox
mthmulders commented on PR #523: URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1101695153 > > Is it possible to find very similar and existing IT with argLine and make such addons with white spaces? > > Looking into that. Strange thing: when I wrote the IT, I mad

[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-18 Thread GitBox
mthmulders commented on PR #523: URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1101635910 > Is it possible to find very similar and existing IT with argLine and make such addons with white spaces? Looking into that. Strange thing: when I wrote the IT, I made sure