[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-02-09 Thread GitBox
oehme commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-776078625 I was referring to the additional validation you wanted me to add - That's possible for surefire (both properties in the same Mojo), but as far as I can see not for failsafe

[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-02-08 Thread GitBox
oehme commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-775011433 I've looked at this and I think it would be inconsistent: Only the SurefirePlugin has both `failOnFlakeCount` and `rerunFailingTestCount`. For integration tests, the two opti

[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-02-05 Thread GitBox
oehme commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-774097056 If you want I can send another PR, otherwise I'll let you take care of it. This is an automated message from

[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-02-03 Thread GitBox
oehme commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-772492203 Added the IT back This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-02-03 Thread GitBox
oehme commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-772337965 @Tibor17 I don't, but I can easily add one back if you want. I removed it because this feature isn't specific to a particular provider and all the logic could be unit tested,

[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-02-01 Thread GitBox
oehme commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-770863637 All fixed up This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-surefire] oehme commented on pull request #333: Add failOnFlakeCount option

2021-01-29 Thread GitBox
oehme commented on pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#issuecomment-769772297 I've clarified the documentation and added unit tests. I've removed the integration test, since this feature is not junit-platform specific, but fully contained in SurefireHe