olamy commented on pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1079535461
done via https://github.com/apache/maven-surefire/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
olamy commented on pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1064657277
> @Tibor17 I hope I answered all your concerns and we can now merge this?
@Tibor17 ping
--
This is an automated message from the Apache Git Service.
To respond to t
olamy commented on pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1062624043
@Tibor17 I hope I answered all your concerns and we can now merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
olamy commented on pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1054754133
> I'm afraid that jacoco not working in IT tests with current
configuration ... maybe I'm wrong
I will have a look but yeah it looks not
--
This is an automat
olamy commented on pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1054711444
> Agree ... surefire code is enough complexity, we should reduce complexity
not increase.
>
> Next question how to test such code with coverage all decision branch?
olamy commented on pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1054680670
> You added one more branching and you call `throwException`.
>
> Why?
>
> It has to end up with the only one exception - `BUILD ERROR` with no other
decision m
olamy commented on pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1054670812
> Your thrown exception does not make sense, because there are two types,
just notice that. If it is a `BUILD FAILURE` then it has not to fail the build
because you configur
