[GitHub] [maven-surefire] rmannibucau commented on pull request #398: [SUREFIRE-1962] Unit test for ProviderInfo#isApplicable

2021-12-21 Thread GitBox
rmannibucau commented on pull request #398: URL: https://github.com/apache/maven-surefire/pull/398#issuecomment-998762279 @slawekjaranowski got it but don't think it has much value without a real setup (skipping the detection which is the point of these selection). That said no big opposit

[GitHub] [maven-surefire] rmannibucau commented on pull request #398: [SUREFIRE-1962] Unit test for ProviderInfo#isApplicable

2021-12-19 Thread GitBox
rmannibucau commented on pull request #398: URL: https://github.com/apache/maven-surefire/pull/398#issuecomment-997662609 Not obvious to me what the goal is and if it is only isApplicable maybe it needs a true/false case for all providers when possible? But likely misses the most importa