[GitHub] [maven-surefire] slawekjaranowski commented on pull request #500: [SUREFIRE-2024] Replace testng-junit5 by testng-engine

2022-03-30 Thread GitBox
slawekjaranowski commented on pull request #500: URL: https://github.com/apache/maven-surefire/pull/500#issuecomment-1082806125 Ok, thanks. I assume that now is ok. So when build have finished I will merge it. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #500: [SUREFIRE-2024] Replace testng-junit5 by testng-engine

2022-03-29 Thread GitBox
slawekjaranowski commented on pull request #500: URL: https://github.com/apache/maven-surefire/pull/500#issuecomment-1081652953 Now with newer version of `testng-engine` is better I think. Simply can be used with the newest `junit-jupiter-api:5.8.2` and simple configuration should be sh

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #500: [SUREFIRE-2024] Replace testng-junit5 by testng-engine

2022-03-28 Thread GitBox
slawekjaranowski commented on pull request #500: URL: https://github.com/apache/maven-surefire/pull/500#issuecomment-1081403804 @Tibor17 Ok, I removed additional test, and use only existing. I think that exclusions in most of time it is workaround for problem in target project.

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #500: [SUREFIRE-2024] Replace testng-junit5 by testng-engine

2022-03-27 Thread GitBox
slawekjaranowski commented on pull request #500: URL: https://github.com/apache/maven-surefire/pull/500#issuecomment-1079988983 Ok, It is only improvement and can be postpone to a later release. But we should know that can generate issues for as, like [SUREFIRE-2043](https://issues.apach

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #500: [SUREFIRE-2024] Replace testng-junit5 by testng-engine

2022-03-27 Thread GitBox
slawekjaranowski commented on pull request #500: URL: https://github.com/apache/maven-surefire/pull/500#issuecomment-1079984393 Another radical proposition, drop this it tests at all, `testng-engine` it is not our product it is extension for junit-platform. So mention in documentati