[GitHub] [maven-verifier] elharo commented on pull request #9: [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions

2022-03-11 Thread GitBox
elharo commented on pull request #9: URL: https://github.com/apache/maven-verifier/pull/9#issuecomment-1065067750 Thanks for the link to mvnrepository. That's more usages than I would have guessed. My gut is that we're not going to remove these methods. Too many projects depend on them alr

[GitHub] [maven-verifier] elharo commented on pull request #9: [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions

2022-03-11 Thread GitBox
elharo commented on pull request #9: URL: https://github.com/apache/maven-verifier/pull/9#issuecomment-1065066209 It's the standard way, assuming step 2 can in fact be done. Far too often, step 2 never happens and the deprecated code is never removed and supported forever. -- This is a

[GitHub] [maven-verifier] elharo commented on pull request #9: [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions

2022-03-10 Thread GitBox
elharo commented on pull request #9: URL: https://github.com/apache/maven-verifier/pull/9#issuecomment-1064485060 It's more of a long term concern. Is anyone who's not the Maven project using this? If so, it's going to be really hard to remove the deprecated methods. I agree that i