[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash

2020-11-24 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733208695 @ok2c Thank you. This is what I have assumed! @volkodava I have pushed branch WAGON-602 which another test, but removed one test because it was logically wrong. As soon as y

[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash

2020-11-24 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733120004 You have to undo the last commit because `URLEncodedUtils` expects encoded paths. This is an automated messag

[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash

2020-11-24 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733089123 I can confirm that HttpClient's `URLEncodedUtils.parsePathSegments("/wow/"))` does what I have expected: `[wow, ]`. We need now a split which retains the last empty element

[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash

2020-11-24 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733056193 Please create a JIRA issue for this. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash

2020-11-24 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-733056024 So I have checked RFC 3986, it does not say anything about path ending normalization. Therefore I have checked WHATWG's URL spec: https://url.spec.whatwg.org/#url-serializing.

[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash

2020-11-24 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-732994229 OK, let me get to the breaking change first: The entire old code has been thrown out because it was defective and did not really comply with RFC 3986. HttpClient offers better

[GitHub] [maven-wagon] michael-o commented on pull request #74: fix encode URL to preserve trailing slash

2020-11-24 Thread GitBox
michael-o commented on pull request #74: URL: https://github.com/apache/maven-wagon/pull/74#issuecomment-732975081 I need to take a closer look before merging this. This is an automated message from the Apache Git Service. To