[GitHub] [maven-wrapper] hazendaz commented on pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

hazendaz commented on PR #44: URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1370262620 @michael-o Ping, any possibility of this being merged before next release happens? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-wrapper] hazendaz commented on pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

hazendaz commented on PR #44: URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1129254265 @michael-o The issue is from how the property file is read. Its reading the entire line so it gets line feed. It really should not pick up the line feed. I have changed the logic to

[GitHub] [maven-wrapper] hazendaz commented on pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

hazendaz commented on PR #44: URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1129200037 The script file can be either windows or Unix based as that doesn't seem to cause issue. Possibly it's from the read of wrapper properties. Tried printing the data there but all look