[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows

2018-11-16 Thread GitBox
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-439592262 @jglick Pls close your PR, the fix has been pushed. Thx for your work!

[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows

2018-11-10 Thread GitBox
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437622572 linked with discussion https://github.com/apache/maven-surefire/pull/199

[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows

2018-11-10 Thread GitBox
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437620227 @cstamas @jglick I could not find in Java specification that element in `Class-Path`

[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows

2018-11-10 Thread GitBox
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437618365 @jglick Pls update your PR with https://github.com/jglick/maven-surefire/pull/1 there are

[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows

2018-11-09 Thread GitBox
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437419749 Currently running the build with our changes...

[GitHub] Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows

2018-11-09 Thread GitBox
Tibor17 commented on issue #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows URL: https://github.com/apache/maven-surefire/pull/198#issuecomment-437408939 @jglick Can you squash the commits together, rebase on the master and create a new Jira