[GitHub] mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject

2019-01-14 Thread GitBox
mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-454018485 All good to me. I'd be happy to see this merged and then a snapshot published. Then if I see further conce

[GitHub] mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject

2019-01-14 Thread GitBox
mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-453958389 @hboutemy Sorry for reporting so late. It's not an easy task and I'm not progressing very fast with this refa

[GitHub] mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject

2019-01-07 Thread GitBox
mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-452032331 @hboutemy I'm trying to get back to work on that one, but with MNG-6530, it's much harder to test it properly

[GitHub] mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject

2019-01-02 Thread GitBox
mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-450911058 > I reworked the PR, creating 2 initial little refactoring commits that make the later modification a lot eas

[GitHub] mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject

2018-12-18 Thread GitBox
mickaelistria commented on issue #197: [MNG-6533] Test: ProjectBuildingException miss reference to MavenProject URL: https://github.com/apache/maven/pull/197#issuecomment-448132618 @hboutemy Thanks, I updated the change according to your comments (I could have missed some style stuff thoug