michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428911493
##
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java:
##
@@ -304,7 +310,7 @@ public String toString(int depth) {
message.append(",
michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428900306
##
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexingSink.java:
##
@@ -104,15 +106,21 @@ private IndexingSink(IndexEntry rootEntry, Sink delegate)
{
michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428795972
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java:
##
@@ -189,6 +229,25 @@ protected boolean isSecondParsing() {
return secondP
michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428794860
##
doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java:
##
@@ -105,6 +110,10 @@ protected void setId(String id) {
this.id = id;
}
michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428794572
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Parser.java:
##
@@ -83,4 +85,34 @@ public interface Parser {
* @return true (default value) if comme
kwin commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428394870
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Parser.java:
##
@@ -83,4 +85,34 @@ public interface Parser {
* @return true (default value) if comment Do
kwin commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428392892
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Parser.java:
##
@@ -83,4 +85,34 @@ public interface Parser {
* @return true (default value) if comment Do
michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428238514
##
doxia-core/src/main/java/org/apache/maven/doxia/parser/Parser.java:
##
@@ -83,4 +85,34 @@ public interface Parser {
* @return true (default value) if comme
michael-o commented on PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1837574750
> > I don't see need to modify/intercept the sink at all, a parser can do
this perfectly with some buffering. TOCMacro does this buffering with a fresh
parser as well.
>
> The
kwin commented on PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1837439220
> I don't see need to modify/intercept the sink at all, a parser can do this
perfectly with some buffering. TOCMacro does this buffering with a fresh parser
as well.
The point is th
michael-o commented on PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1837260464
> > This seems like a reimplementation of RandomAccessSink: The
RandomAccessSink provides the ability to create a {https://github.com/link
Sink} with hooks. Why not evaluate it if it
kwin commented on PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1831556494
> This seems like a reimplementation of RandomAccessSink: The
RandomAccessSink provides the ability to create a {https://github.com/link
Sink} with hooks. Why not evaluate it if it there.
michael-o commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1408359647
##
doxia-core/src/main/java/org/apache/maven/doxia/macro/MacroRequest.java:
##
@@ -40,15 +40,23 @@ public class MacroRequest {
/** A map of parameters. */
kwin commented on code in PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1408134053
##
doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/NamesForIndexEntriesSinkWrapper.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundatio
14 matches
Mail list logo
