Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2024-01-10 Thread via GitHub
slachiewicz merged PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-29 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872333258 @slachiewicz I have added a temporary fix. This requires https://github.com/apache/maven-doxia/pull/187 to be merged first. -- This is an automated message from the

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-29 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872274339 Doxia is broken: `xmlReader = XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");` Let me fix/evaluate this before we continue... -- This is

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-29 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872244289 Checking... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-29 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871876782 > If I understand correctly, I'll remove here dependency to Xerces and then wait until it will not be needed by Doxia core. I cannot see where Doxia Core uses

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-28 Thread via GitHub
slachiewicz commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871589822 If I understand correctly, I'll remove here dependency to Xerces and then wait until it will not be needed by Doxia core. -- This is an automated message from the

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-28 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871488254 https://github.com/HtmlUnit/htmlunit-neko/blob/master/README.md#porting-from-2x-to-3x -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-28 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871487656 Do you understand this https://github.com/HtmlUnit/htmlunit-neko/commit/6cf26c01693e8f16466f0f33a5e4467f0b67fc75? -- This is an automated message from the Apache Git

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-28 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871484688 > I wasn't able to find where we pull similar dependency dependency in Doxia core. Here it was working because of old html unit test dependency

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-28 Thread via GitHub
slachiewicz commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871483498 I wasn't able to find where we pull similar dependency dependency in Doxia core. Here it was working because of old html unit test dependency -- This is an automated

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-28 Thread via GitHub
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871475907 Why isn't this a transtive dep? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]

2023-12-27 Thread via GitHub
slachiewicz commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1870619400 https://github.com/advisories/GHSA-3xrr-7m6p-p7xh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and