kwin commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-2009951837
Superseded by #140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kwin closed pull request #126: [DOXIASITETOOLS-324] Allow configuration of
Doxia parser
URL: https://github.com/apache/maven-doxia-sitetools/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
michael-o commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1925705327
> There is some issues with the tests I have not fully understood yet
(duplicate anchors). Therefore putting this PR back to draft modus. @michael-o
Have you thought about
kwin commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1925656300
There is some issues with the tests I have not fully understood yet
(duplicate anchors). Therefore putting this PR back to draft modus. @michael-o
Have you thought about using r
michael-o commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1925434563
@kwin Can you take care of the failing tests? I want to complete the review
this month.
--
This is an automated message from the Apache Git Service.
To respond to the mes
michael-o commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890769500
> I know about the failing tests: [#126
(comment)](https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1884787622)
Though, #124 has been merged. Sho
kwin commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890767593
I know about the failing tests:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1884787622
--
This is an automated message from the Apache Git Service.
T
michael-o commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1890752975
@kwin Can you please double-check tests, they fail for me:
```
[INFO] Running org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest
[main] WARN org.apache.mave
michael-o commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-188674
> > We always operate on parser modules consistently, thus I would expect
that a parser config applies on a per-module basis.
>
> You are probably right, a config map
kwin commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1886854816
> We always operate on parser modules consistently, thus I would expect
that a parser config applies on a per-module basis.
You are probably right, a config mapping per
kwin commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1884787622
@michael-o Not sure why the build fails now, seems related to #124 but not
sure why master is not affected. Maybe we can merge #124 first.
--
This is an automated message from
michael-o commented on PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#issuecomment-1884733225
I'll need a bit more time. I need to review this in tandem with the Maven
Site Plugin PR.
--
This is an automated message from the Apache Git Service.
To respond to the m
kwin commented on code in PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#discussion_r1443971657
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfiguration.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software
kwin commented on code in PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#discussion_r1443970810
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -388,4 +391,20 @@ public File getRootDirectory() {
michael-o commented on code in PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#discussion_r1443866765
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/ParserConfiguration.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Sof
kwin commented on code in PR #126:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/126#discussion_r1442152573
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java:
##
@@ -320,9 +337,13 @@ public void renderDocument(
kwin opened a new pull request, #126:
URL: https://github.com/apache/maven-doxia-sitetools/pull/126
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
17 matches
Mail list logo
