Re: [PR] [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload [maven-deploy-plugin]

2024-08-15 Thread via GitHub
sratz commented on PR #42: URL: https://github.com/apache/maven-deploy-plugin/pull/42#issuecomment-2291598288 Awesome, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload [maven-deploy-plugin]

2024-08-14 Thread via GitHub
cstamas commented on PR #42: URL: https://github.com/apache/maven-deploy-plugin/pull/42#issuecomment-2288709684 Superded by https://github.com/apache/maven-deploy-plugin/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload [maven-deploy-plugin]

2024-08-14 Thread via GitHub
cstamas closed pull request #42: [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload URL: https://github.com/apache/maven-deploy-plugin/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload [maven-deploy-plugin]

2024-06-13 Thread via GitHub
EnigmaTriton commented on code in PR #42: URL: https://github.com/apache/maven-deploy-plugin/pull/42#discussion_r1638662304 ## src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java: ## @@ -274,9 +274,7 @@ public void execute() throws MojoExecutionException, MojoFai

Re: [PR] [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload [maven-deploy-plugin]

2024-06-13 Thread via GitHub
EnigmaTriton commented on code in PR #42: URL: https://github.com/apache/maven-deploy-plugin/pull/42#discussion_r1638662304 ## src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java: ## @@ -274,9 +274,7 @@ public void execute() throws MojoExecutionException, MojoFai

Re: [PR] [MDEPLOY-311] Pass on 'packaging' when creating artifact to upload [maven-deploy-plugin]

2023-10-23 Thread via GitHub
cstamas commented on PR #42: URL: https://github.com/apache/maven-deploy-plugin/pull/42#issuecomment-1776170234 Something is fishy about this PR, but I think I understand the intent is the generated POM/packaging wrong? -- This is an automated message from the Apache Git Service. To