asfgit merged PR #236:
URL: https://github.com/apache/maven-plugin-tools/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@mav
asfgit closed pull request #236: [MNG-5695] document Maven 3.2.5+ scoped
components usage
URL: https://github.com/apache/maven-plugin-tools/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
michael-o commented on PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1870647715
I took the stab now and change the code: #253. Both PRs should go together
in the next release.
--
This is an automated message from the Apache Git Service.
To respond to th
michael-o commented on PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1869096681
> We also should remove replacements and worning form code:
>
>
https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-annotations/src/main/java/org
michael-o commented on PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1869075954
Are we good to merge this? We have two approvals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
hboutemy commented on PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1809312591
on latest discussions on Slack (I hate non-shared Slack diuscussions), there
is also the `@Inject` options that IIUC completely avoids the plugin descriptor
intermediate= `http
hboutemy commented on PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1809309881
before Maven 3.2.5, they were not Plexus components: then implementation in
plexus-tools was a hack to replace with parameter in plugin descriptor XML
--
This is an automated
cstamas commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1383237666
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
gnodet commented on PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1794259016
> in [MPLUGIN-204](https://issues.apache.org/jira/browse/MPLUGIN-204) we
advised using `@Component` (that would use the trick to transform to parameters
in the plugin descriptor
hboutemy commented on PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1794214621
in MPLUGIN-204 we advised using `@Component` (that would use the trick to
transform to parameters in the plugin descriptor XML), but later we advised
back:
https://github.com/
hboutemy commented on PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#issuecomment-1794131746
now that we've found back the MPLUGIN-204 hack, in the proposed update:
```
@Component // since Maven 3.2.5, thanks to MNG-5695
```
we could perhaps drop the comment
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382637654
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382636597
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382636597
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382637654
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382637654
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
michael-o commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382637412
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponen
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382636597
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382636597
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
hboutemy commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382636597
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent
michael-o commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382595128
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponen
gnodet commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382594121
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent c
michael-o commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382592626
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponen
gnodet commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382564308
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyComponent c
slawekjaranowski commented on code in PR #236:
URL:
https://github.com/apache/maven-plugin-tools/pull/236#discussion_r1382531856
##
maven-plugin-tools-annotations/src/site/apt/index.apt:
##
@@ -94,27 +94,42 @@ public class MyMojo
hint = "..." )
private MyC
hboutemy opened a new pull request, #236:
URL: https://github.com/apache/maven-plugin-tools/pull/236
clarify something which precise scope was unclear until now (at least to me)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
26 matches
Mail list logo
