pdeneve commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-2347095806
Cool, will check it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
gnodet closed pull request #1205: [MNG-5862] Support XML entities and XInclude
URL: https://github.com/apache/maven/pull/1205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gnodet commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-2345748715
An extension will be available at
https://github.com/apache/maven-xinclude-extension
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
gnodet commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-2211723621
This should become a separate Maven extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cowtowncoder commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1889696106
I remember thinking about XInclude at some point wrt Woodstox, but it seemed
rather complicated to support for a streaming parser. So likely it'd instead
need to be some processor on t
scantor commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1887792723
> The stigma surrounding xinclude is really quite infuriating. Is there a
feature more maligned than this?
Yes, entities, deservedly so. That was actually more my concern. I have no
delanym commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1887778841
The stigma surrounding xinclude is really quite infuriating. Is there a
feature more maligned than this? The disparity between its notoriety and its
simplicity is something almost poetic.
scantor commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1887424473
> > A personal project won't really work, but is there any way this can go
into Woodstox or the Apache XML project or something like that?
>
> @cotowncoder ? @scantor ?
Umm. Ma
gnodet commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1887400996
> A personal project won't really work, but is there any way this can go
into Woodstox or the Apache XML project or something like that?
@cotowncoder ? @scantor ?
--
This is an auto
elharo commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1887167534
A personal project won't really work, but is there any way this can go into
Woodstox or the Apache XML project or something like that?
--
This is an automated message from the Apache Git S
gnodet commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1886753042
> Mostly nits.
They should be all fixed now.
> More generally, rereading this I'm struck at how much work this is. You've
provided a nearly complete XInclude implementation. The
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1448088770
##
api/maven-api-core/src/main/java/org/apache/maven/api/feature/Features.java:
##
@@ -62,6 +64,18 @@ public static boolean buildConsumer(@Nullable Session
session) {
norrisjeremy commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1447425063
##
api/maven-api-core/src/main/java/org/apache/maven/api/feature/Features.java:
##
@@ -62,6 +64,18 @@ public static boolean buildConsumer(@Nullable Session
session)
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1447401146
##
maven-stax-xinclude/src/main/java/org/apache/maven/stax/xinclude/NCName.java:
##
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1447394483
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -147,4 +175,18 @@ private Model read(Reader reader, Path pomFile,
Map option
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446522303
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -100,14 +104,39 @@ private Path getRootDirectory(Map options) {
retu
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446520142
##
api/maven-api-core/src/main/java/org/apache/maven/api/feature/Features.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
elharo commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446059983
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -100,14 +104,39 @@ private Path getRootDirectory(Map options) {
retu
gnodet commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1883027717
One possibility would be to create an extension to support this feature.
This should be possible as the entities/xinclude are only processed at build
time and the consumer pom is flattened.
pdeneve commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1882239484
@gnodet Thanks for you work. Any plans on resolving the requested change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
20 matches
Mail list logo
