asfgit merged PR #1362:
URL: https://github.com/apache/maven/pull/1362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michael-o commented on PR #1362:
URL: https://github.com/apache/maven/pull/1362#issuecomment-1879829855
@slachiewicz As requested...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asfgit merged PR #1361:
URL: https://github.com/apache/maven/pull/1361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fanshichao commented on PR #1362:
URL: https://github.com/apache/maven/pull/1362#issuecomment-1879823720
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
michael-o opened a new pull request, #1362:
URL: https://github.com/apache/maven/pull/1362
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.
Also, parametersMap did not honor parameter
ordering while parameters list makes it look
michael-o commented on PR #1361:
URL: https://github.com/apache/maven/pull/1361#issuecomment-1877694981
@cstamas Any objections before I backport this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
michael-o commented on PR #1361:
URL: https://github.com/apache/maven/pull/1361#issuecomment-1877694799
> good, maybe it's also worth to backport to 3.8.x?
I was thinking about the same. Will prepare after this one.
--
This is an automated message from the Apache Git Service.
To
slawekjaranowski commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440897194
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -51,9 +52,7 @@ public class MojoDescriptor extends
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440868896
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -51,9 +52,7 @@ public class MojoDescriptor extends ComponentDescriptor
slawekjaranowski commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440780384
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -51,9 +52,7 @@ public class MojoDescriptor extends
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440639115
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440632936
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440629527
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
kwin commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440618341
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440420958
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
kwin commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440413993
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
michael-o commented on PR #1361:
URL: https://github.com/apache/maven/pull/1361#issuecomment-1874589827
@slawekjaranowski This is a cherrypick from master. It does not change
behavior. Unmodifiables should on main only and require a new issue. Note that
this will need special handling in
slawekjaranowski commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1439751661
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -198,31 +200,25 @@ public void setParameters(List parameters)
michael-o commented on PR #1361:
URL: https://github.com/apache/maven/pull/1361#issuecomment-1874393484
As a result of https://github.com/apache/maven-plugin-tools/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
michael-o opened a new pull request, #1361:
URL: https://github.com/apache/maven/pull/1361
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.
Also, parametersMap did not honor parameter
ordering while parameters list makes it look
20 matches
Mail list logo
