Re: [PR] [MNG-7344] track dependencyManagement import location in effective Model for MPH-183 [maven]

2024-04-12 Thread via GitHub
juulhobert commented on code in PR #603: URL: https://github.com/apache/maven/pull/603#discussion_r1562205753 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java: ## @@ -1683,13 +1684,20 @@ private void importDependencyManagement(

Re: [PR] [MNG-7344] track dependencyManagement import location in effective Model for MPH-183 [maven]

2024-04-12 Thread via GitHub
Giovds commented on code in PR #603: URL: https://github.com/apache/maven/pull/603#discussion_r1562165582 ## api/maven-api-model/src/main/java/org/apache/maven/api/model/InputSource.java: ## @@ -64,6 +74,14 @@ public String getModelId() { return this.modelId; }

Re: [PR] [MNG-7344] track dependencyManagement import location in effective Model for MPH-183 [maven]

2024-04-01 Thread via GitHub
hboutemy commented on code in PR #603: URL: https://github.com/apache/maven/pull/603#discussion_r1546843401 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java: ## @@ -1683,13 +1684,20 @@ private void importDependencyManagement(

Re: [PR] [MNG-7344] track dependencyManagement import location in effective Model for MPH-183 [maven]

2024-04-01 Thread via GitHub
hboutemy commented on code in PR #603: URL: https://github.com/apache/maven/pull/603#discussion_r1546645631 ## api/maven-api-model/src/main/java/org/apache/maven/api/model/InputLocation.java: ## @@ -83,6 +95,13 @@ public Map getLocations() { return locations; }

Re: [PR] [MNG-7344] track dependencyManagement import location in effective Model for MPH-183 [maven]

2024-03-31 Thread via GitHub
hboutemy commented on code in PR #603: URL: https://github.com/apache/maven/pull/603#discussion_r1545568921 ## api/maven-api-model/src/main/java/org/apache/maven/api/model/InputLocation.java: ## @@ -83,6 +95,13 @@ public Map getLocations() { return locations; }