Re: [PR] [MNG-7854] Warn if imported depMgt is ignored as it already exists [maven]

2024-01-10 Thread via GitHub
cstamas commented on PR #1211: URL: https://github.com/apache/maven/pull/1211#issuecomment-1885265685 Superseded by https://github.com/apache/maven/pull/1370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [MNG-7854] Warn if imported depMgt is ignored as it already exists [maven]

2024-01-10 Thread via GitHub
cstamas closed pull request #1211: [MNG-7854] Warn if imported depMgt is ignored as it already exists URL: https://github.com/apache/maven/pull/1211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [MNG-7854] Warn if imported depMgt is ignored as it already exists [maven]

2023-12-16 Thread via GitHub
cstamas commented on PR #1211: URL: https://github.com/apache/maven/pull/1211#issuecomment-1858938975 I still believe, that if this warning would be emitted, no "self conflicting" BOMs would be produced like that one above. -- This is an automated message from the Apache Git Service. To

Re: [PR] [MNG-7854] Warn if imported depMgt is ignored as it already exists [maven]

2023-11-17 Thread via GitHub
cstamas commented on PR #1211: URL: https://github.com/apache/maven/pull/1211#issuecomment-1816745193 Well, here is a counter example: I have no **conflicting imports** as I import just one: ``` 4.0.0 org.cstamas test 1.0.0 jar

Re: [PR] [MNG-7854] Warn if imported depMgt is ignored as it already exists [maven]

2023-11-17 Thread via GitHub
gnodet commented on PR #1211: URL: https://github.com/apache/maven/pull/1211#issuecomment-1816684817 The idea looks good to me. There's one additional use case that needs to be handled though is the following. Let's say one or two BOMs are imported with a conflicting dependency.