Re: [PR] [MNG-8211] Fail the build if CI Friendly revision used without value [maven]

2024-08-22 Thread via GitHub
cstamas merged PR #1656: URL: https://github.com/apache/maven/pull/1656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8211] Fail the build if CI Friendly revision used without value [maven]

2024-08-22 Thread via GitHub
cstamas commented on PR #1656: URL: https://github.com/apache/maven/pull/1656#issuecomment-2304358515 Last example of failure but also the "escape hatch" in effect: https://gist.github.com/cstamas/1e880b2381bf1c543db052a1298e5074 -- This is an automated message from the Apache Git Service

Re: [PR] [MNG-8211] Fail the build if CI Friendly revision used without value [maven]

2024-08-21 Thread via GitHub
cstamas commented on PR #1656: URL: https://github.com/apache/maven/pull/1656#issuecomment-2301604056 This PR would really help to reduce user confusion with CI Friendly version. Combined with Nisse https://github.com/maveniverse/nisse they can have full experience. -- This is an autom

Re: [PR] [MNG-8211] Fail the build if CI Friendly revision used without value [maven]

2024-08-20 Thread via GitHub
cstamas commented on PR #1656: URL: https://github.com/apache/maven/pull/1656#issuecomment-2299780307 Example of failure: https://gist.github.com/cstamas/01b1b6152aca56f1383148ef74245583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [MNG-8211] Fail the build if CI Friendly revision used without value [maven]

2024-08-20 Thread via GitHub
cstamas commented on PR #1656: URL: https://github.com/apache/maven/pull/1656#issuecomment-2299753621 This PR does it in wrong place: * this should happen in validator when validating effective model? -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] [MNG-8211] Fail the build if CI Friendly revision used without value [maven]

2024-08-15 Thread via GitHub
laeubi commented on code in PR #1656: URL: https://github.com/apache/maven/pull/1656#discussion_r1718560854 ## maven-model-builder/src/main/java/org/apache/maven/model/interpolation/AbstractStringBasedModelInterpolator.java: ## @@ -158,6 +160,16 @@ public Object getValue(String

Re: [PR] [MNG-8211] Fail the build if CI Friendly revision used without value [maven]

2024-08-15 Thread via GitHub
cstamas commented on PR #1656: URL: https://github.com/apache/maven/pull/1656#issuecomment-2291423642 Example failure: https://gist.github.com/cstamas/9dbb79be59ba22b6bc5c823d95593e50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to