michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1880017150
> Sorry for the late intervention. I'm not completely sure about
discouraging the use of ${project.xxx} expressions. The reason is that they may
be needed to understand what
gnodet commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1880011647
Sorry for the late intervention. I'm not completely sure about discouraging
the use of ${project.xxx} expressions.
The reason is that they may be to understand what the exact
asfgit closed pull request #253: [MPLUGIN-495] WARNINGs based on usage of
@Component for MavenSession/MavenProject instead of @Parameter
URL: https://github.com/apache/maven-plugin-tools/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1873053871
If I don't hear any objections the next couple of days I will merge this PR
and the one with the docs update. @slawekjaranowski's fix on MDEP can be
applied to all affected
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872494084
I have changed the comment regarding 3.6.2 because that statement is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872263806
> Parameter list can be null ... we also need a fix like:
>
> ```diff
> ---
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872082488
Parameter list can be null ... we also need a fix like:
```diff
---
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871973607
We can remove
`org.apache.maven.tools.plugin.util.PluginUtils#MAVEN_COMPONENTS`
--
This is an automated message from the Apache Git Service.
To respond to the
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871963058
https://github.com/apache/maven-dependency-plugin/pull/360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871962667
> > hm, nope, i assumed this PR fails to build
>
> It works, but not the subsequent use in tests. ITs do work, actually. So I
guessed that some dep is
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871463085
> hm, nope, i assumed this PR fails to build
It works, but not the subsequent use in tests. ITs do work, actually. So I
guessed that some dep is missing during
cstamas commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871461690
hm, nope, i assumed this PR fails to build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871461235
> Hm, with 3.9.6 it "works for me"
Did you build a snapshot of this and apply it to Maven Dependency Plugin?
```
cstamas commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871460369
Hm, with 3.9.6 it "works for me"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871449831
> OutOfScopeException
Yes, 3.8.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cstamas commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871448518
OutOfScopeException of MavenProject. You used Maven 4.0.0-alpha-10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871446556
@cstamas Any ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871431696
I jave just tried a snapshot against Maven Dependency Plugin as @khmarbaise
has reported. I get:
```
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR]
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871416192
> We also have the same in `JavaJavadocMojoDescriptorExtractor` should be
removed too.
Working on it. At some point (4.0.0) we should consider dropping support for
slawekjaranowski commented on code in PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#discussion_r1437444720
##
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java:
##
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1870894763
We also have the same in `JavaJavadocMojoDescriptorExtractor` should be
removed too.
--
This is an automated message from the Apache Git Service.
To respond to the
michael-o opened a new pull request, #253:
URL: https://github.com/apache/maven-plugin-tools/pull/253
This closes #253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
22 matches
Mail list logo
