kwin merged PR #1638:
URL: https://github.com/apache/maven/pull/1638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
gnodet commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2284031732
> > So if you're targeting master, I'm not sure this PR is really needed.
>
> We are somehow going in cycles with this PR: @gnodet I think we agreed
that even for Plugin Descriptor v2
kwin commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2283943537
> So if you're targeting master, I'm not sure this PR is really needed.
We are somehow going in cycles with this PR:
@gnodet I think we agreed that even for Plugin Descriptor v2 the
`
cstamas commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2283865923
Same question here: IF this goes to master, the deprecation message is plain
wrong (mvn4 API has DI annotation, and not JSR330 is to be used). Am unsure is
this PR really needed.
--
This
gnodet commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2283561255
So if you're targeting master, I'm not sure this PR is really needed. @kwin
wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kwin commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2282890500
v4 is using plugin descriptor 2.0. Having `requirements` only for version
1.0 and 1.1 makes it disappear in 2.0 (just look at the generated doc from
modello)
--
This is an automated message
gnodet commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2282885403
> Does that mean the plugin descriptors for v4 should no longer contain
those?
It doesn't afaik.
https://github.com/apache/maven/blob/master/api/maven-api-plugin/src/main/mdo/plugi
kwin commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2282812496
Does that mean the plugin descriptors for v4 should no longer contain those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
gnodet commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2282811177
> @gnodet Have you deliberately removed that from the plugin descriptor
2.0.0? It is still written in
https://github.com/apache/maven-plugin-tools/blob/9332b09acc08d2e063f12a8158a57ca8ec56fa
kwin commented on PR #1638:
URL: https://github.com/apache/maven/pull/1638#issuecomment-2280592748
@gnodet Have you deliberately removed that from the plugin descriptor 2.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
kwin opened a new pull request, #1638:
URL: https://github.com/apache/maven/pull/1638
It is already removed for 2.0.0
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira
11 matches
Mail list logo
