ctubbsii commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1905091600
> > Local builds are affected
>
> Not sure how. Usually local builds are either multi-module or 'installed'
and do not use snapshot repository anyway.
This isn't
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1893341924
> Local builds are affected
Not sure how. Usually local builds are either multi-module or 'installed'
and do not use snapshot repository anyway.
GH actions don't u
kwin commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1893308232
Local builds are affected, GitHub actions are affected (everything which
does not use a centrally managed `settings.xml` with that repo in it), so yes
from my perspective the impa
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1893295331
> create a huge headache for all downstream users of this, who use the ASF
parent POM to build multi-module snapshots
I also want to reiterate that multi-module projects
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1892813758
Is this really a lot of impact? Also, doesn't Apache Jenkins have this
build-in as well?
--
This is an automated message from the Apache Git Service.
To respond to the messag
kwin commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1892806824
Every multi repo ASF project with inter repo dependencies needs that from
time to time.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1892801402
> this causes too much friction
I still don't see this friction. Let's look at the actual use case where
this is used.
The only use case I see is when the Apache proje
ctubbsii commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1877686303
> > A lot of projects rely on this being already set up
>
> Understandable, but since these upgrades don't happen automatically and
"fail fast", I don't see this as a bi
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1875630975
> A lot of projects rely on this being already set up
Understandable, but since these upgrades don't happen automatically and
"fail fast", I don't see this as a big issue
ctubbsii commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1875601253
> > this is probably going to create a huge headache
>
> Why? It's not difficult to put those lines into `settings.xml` in their
own profile, on the CI system where they
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1874715383
> this is probably going to create a huge headache
Why? It's not difficult to put those lines into `settings.xml` on the CI
system where they belong
--
This is an aut
ctubbsii commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1874710714
If these are removed, this is probably going to create a huge headache for
all downstream users of this, who use the ASF parent POM to build multi-module
snapshots.
--
This
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869956490
@kwin See https://github.com/apache/shiro/pull/1245 for an example
Introducing test failure doesn't actually produce a failure, due to maven
resolver pulling the older snapsh
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869863388
Will try that. Thank you!
Even if that works I still think the repository entries should be removed.
--
This is an automated message from the Apache Git Service.
To re
olamy commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869851414
Maybe configure dependabot
# Add Maven Central explicitly to work around:
# https://github.com/dependabot/dependabot-core/issues/8329
registries:
maven-cent
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869719981
Also see this Slack discussion:
https://the-asf.slack.com/archives/C7Q9JB404/p1703540867035689
--
This is an automated message from the Apache Git Service.
To respond to the
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869719758
Just did a quick google search "why repository in pom bad" and found this:
https://blog.sonatype.com/2009/02/why-putting-repositories-in-your-poms-is-a-bad-idea/#:~:text=
kwin commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869714292
Please give some reasons, except for unclear downstream issues. This is very
helpful for most ASF projects is my argument for keeping it in that place!
--
This is an automated m
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869713540
There is also a matter of pragmatism here. The repository entries really
shouldn't be there in the first place. No matter what the downstream issues
are, those should be remove
kwin commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869711752
IMHO adding the ASF snapshot repo shouldn't do any harm for projects not
leveraging it. So let us rather track the downstream issues separately here.
--
This is an automated mes
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869707135
> This sounds like an issue with your reactor then.
Not sure what it could possibly be. It took me 3+ hours of debugging to
figure out why the builds weren't working corr
kwin commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869336627
This sounds like an issue with your reactor then. Maven only tries to
download dependencies which are not part of the current multimodule build.
Some projects from ASF rely on
lprimak commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869282649
For example, in Apache Shiro, they download SNAPSHOT versions from the
repository during CI builds instead of using the local CI-build artifacts.
--
This is an automated mess
ctubbsii commented on PR #183:
URL:
https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1869266923
How do these interfere with downstream builds? Shouldn't they only impact
SNAPSHOT builds which, since they are for non-released code, should not have
any impact on downstream
lprimak opened a new pull request, #183:
URL: https://github.com/apache/maven-apache-parent/pull/183
Snapshot repositories interfere with downstream builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lprimak closed pull request #182: [MPOM-451] Remove repository elements from
Apache Parent
URL: https://github.com/apache/maven-apache-parent/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lprimak opened a new pull request, #182:
URL: https://github.com/apache/maven-apache-parent/pull/182
Snapshot repositories interfere with downstream builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
27 matches
Mail list logo
