Re: [PR] [MRELEASE-1109] Support CI friendly versions [maven-release]

2024-08-23 Thread via GitHub
michael-o commented on PR #198: URL: https://github.com/apache/maven-release/pull/198#issuecomment-2306758593 After all, this isn't fine anymore. This has introduced anothe regression: https://issues.apache.org/jira/browse/MRELEASE-1154 -- This is an automated message from the Apache Git

Re: [PR] [MRELEASE-1109] Support CI friendly versions [maven-release]

2023-11-29 Thread via GitHub
mkolesnikov commented on code in PR #198: URL: https://github.com/apache/maven-release/pull/198#discussion_r1409846744 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -89,6 +92,18 @@ public abstract class Abstract

Re: [PR] [MRELEASE-1109] Support CI friendly versions [maven-release]

2023-11-29 Thread via GitHub
mkolesnikov commented on code in PR #198: URL: https://github.com/apache/maven-release/pull/198#discussion_r1409843204 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -189,7 +192,17 @@ public void setVersion(String ver

Re: [PR] [MRELEASE-1109] Support CI friendly versions [maven-release]

2023-11-29 Thread via GitHub
mkolesnikov commented on code in PR #198: URL: https://github.com/apache/maven-release/pull/198#discussion_r1409835601 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java: ## @@ -89,6 +92,18 @@ public abstract class Abstract

Re: [PR] [MRELEASE-1109] Support CI friendly versions [maven-release]

2023-11-29 Thread via GitHub
mkolesnikov commented on code in PR #198: URL: https://github.com/apache/maven-release/pull/198#discussion_r1409822004 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -189,7 +192,17 @@ public void setVersion(String ver