Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
rmannibucau commented on code in PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#discussion_r1512251552 ## src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java: ## @@ -60,18 +64,27 @@ public class EvalMojo extends AbstractMojo { @Parameter

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
hboutemy commented on code in PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#discussion_r1512093998 ## src/main/java/org/apache/maven/plugins/scripting/EvalMojo.java: ## @@ -60,18 +64,27 @@ public class EvalMojo extends AbstractMojo { @Parameter S

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
bmarwell commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1977523999 I'm somewhere between the lines here. If you have a common use case, a dedicated plugin is probably a better solution compared to the exec-, antrun-, or scripting-plugin.

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
rmannibucau commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1977445949 @cstamas I'm on the camp to enable people to do what works for them, for me maven key is dependencies and it must stay static, rest (build pipeline) already broke maven orig

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
cstamas commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1977439877 It is not all black or white of course. We do need some "backdoors" open, for case of "emergency", if no plugin exists that does what you need. But if you google it, you w

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
bmarwell commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1977407591 > This is a matter of principle, and IMHO, vision. > > Plugins like these are like "swiss knives" and allows hacking, in effect, like Ant or other tools allow it (and mak

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
cstamas commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1977397396 This is a matter of principle, and IMHO, vision. Plugins like these are like "swiss knives" and allows hacking, in effect, like Ant or other tools allow it (and makes Mave

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
rmannibucau commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1977388097 @cstamas any rational behind and proposal to solve the related issue (enable to do proper resolutions from the script)? -- This is an automated message from the Apache Git

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
cstamas commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1977364279 A big -1 here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
bmarwell commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1977359977 Re-opened for new evaluation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-04 Thread via GitHub
rmannibucau opened a new pull request, #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSCRIPTING)

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-03 Thread via GitHub
rmannibucau commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1975371685 @bmarwell this is true but this is also something the script somehow know in the context of a project. What would be more useful is a replacement for plexus container to loo

Re: [PR] [MSCRIPTING-7] binding the session and servers helper in binding context [maven-scripting-plugin]

2024-03-03 Thread via GitHub
bmarwell commented on PR #4: URL: https://github.com/apache/maven-scripting-plugin/pull/4#issuecomment-1975340815 You could also add: ``` bindings.put( "pluginDescriptor", pluginDescriptor ); bindings.put( "mojoExecution", mojoExecution ); ``` from #7