hboutemy commented on PR #208:
URL:
https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1919653757
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hboutemy merged PR #208:
URL: https://github.com/apache/maven-shade-plugin/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@m
garydgregory commented on PR #208:
URL:
https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1879713133
https://issues.apache.org/jira/browse/MSHADE-462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
CrazyHZM commented on PR #208:
URL:
https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1879687922
> Shouldn't we have a unit test to avoid this regression in the first place?
I already add it for this case.
--
This is an automated message from the Apache Git Service
garydgregory commented on PR #208:
URL:
https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1878411401
Shouldn't we have a unit test to avoid this regression in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
CrazyHZM opened a new pull request, #208:
URL: https://github.com/apache/maven-shade-plugin/pull/208
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSHADE) filed