Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]

2024-01-31 Thread via GitHub
hboutemy commented on PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1919653757 thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]

2024-01-31 Thread via GitHub
hboutemy merged PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]

2024-01-06 Thread via GitHub
garydgregory commented on PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1879713133 https://issues.apache.org/jira/browse/MSHADE-462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]

2024-01-06 Thread via GitHub
CrazyHZM commented on PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1879687922 > Shouldn't we have a unit test to avoid this regression in the first place? I already add it for this case. -- This is an automated message from the Apache Git Service

Re: [PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]

2024-01-05 Thread via GitHub
garydgregory commented on PR #208: URL: https://github.com/apache/maven-shade-plugin/pull/208#issuecomment-1878411401 Shouldn't we have a unit test to avoid this regression in the first place? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] [MSHADE-462] 3.5.1 not compatible with 3.4.1: The version cannot be empty [maven-shade-plugin]

2024-01-04 Thread via GitHub
CrazyHZM opened a new pull request, #208: URL: https://github.com/apache/maven-shade-plugin/pull/208 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE) filed