asfgit closed pull request #19: [MSHARED-1326] Improve (documentation on)
MavenReport interface
URL: https://github.com/apache/maven-reporting-api/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
michael-o commented on PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1793761975
@kriegaex, any further objections before I merge this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
elharo commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1382472623
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,10 +53,25 @@ public interface MavenReport {
void generate(Sink sink, Locale locale)
michael-o commented on PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1793560561
> good clarification
Is the method name change acceptable for you and reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message
michael-o commented on PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1793479323
Now added `#getOutputPath()` and deprecate `#getOutputName()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kriegaex commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380963374
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
void generate(Sink sink, Locale locale)
michael-o commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380649425
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
void generate(Sink sink, Locale local
michael-o commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380636744
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
void generate(Sink sink, Locale local
elharo commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380634183
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
void generate(Sink sink, Locale locale)
michael-o commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380623760
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
void generate(Sink sink, Locale local
michael-o commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380623760
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
void generate(Sink sink, Locale local
elharo commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380616343
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,9 +53,10 @@ public interface MavenReport {
void generate(Sink sink, Locale locale)
michael-o commented on PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1791230206
@elharo I tried to apply all of your comments. Maybe the method has to
renamed to:
```java
String getOutputPath()
```
since `Name` is misleading...?
--
This is an
elharo commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380023006
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
void generate(Sink sink, Locale locale) t
elharo commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1380023006
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
void generate(Sink sink, Locale locale) t
michael-o commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379691836
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
void generate(Sink sink, Locale locale
michael-o commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379691836
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
void generate(Sink sink, Locale locale
kriegaex commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379470012
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -84,14 +86,17 @@ public interface MavenReport {
String getDescription(Locale locale);
elharo commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379489332
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
void generate(Sink sink, Locale locale) t
kriegaex commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379471594
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
void generate(Sink sink, Locale locale)
kriegaex commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379470012
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -84,14 +86,17 @@ public interface MavenReport {
String getDescription(Locale locale);
kriegaex commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379470012
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -84,14 +86,17 @@ public interface MavenReport {
String getDescription(Locale locale);
kriegaex commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1379467965
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -53,7 +53,9 @@ public interface MavenReport {
void generate(Sink sink, Locale locale)
elharo commented on code in PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#discussion_r1378734859
##
src/main/java/org/apache/maven/reporting/MavenReport.java:
##
@@ -84,14 +86,17 @@ public interface MavenReport {
String getDescription(Locale locale);
michael-o commented on PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1788619992
@elharo As you are a native English speaker and we don't, would you mind to
add your opinion on this?
--
This is an automated message from the Apache Git Service.
To respond
kriegaex commented on PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1786288822
> I believe that the last one is logically wrong.
I do not think so, because it dependes on the context and the assumptions
under which users read the documentation. My co
michael-o commented on PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1784082469
@kriegaex I'd first to normalize the following:
shared report output directory
vs.
base report output directory
vs.
report base out
michael-o commented on PR #19:
URL:
https://github.com/apache/maven-reporting-api/pull/19#issuecomment-1774184321
@kriegalex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
28 matches
Mail list logo
