turbanoff commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1934740436
I believe most of developers want to have logs for failed tests. Because
often it's what we only have to investigate test failures on CI. Sometimes for
rarely failing tests it's th
zabetak commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1934691920
Personally, most of the time I would prefer not to have the STDOUT/STDERR in
the XML report especially for tests that run successfully. I think the best
would be to configure loggers
michael-o commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1934489199
> > The code contradicts the issue summary. Either one should be picked.
>
> Sure that is an obvious problem. It seems though that we all kind of agree
with the idea in the c
zabetak commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1928963618
> The code contradicts the issue summary. Either one should be picked.
Sure that is an obvious problem. It seems though that we all kind of agree
with the idea in the code so w
michael-o commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1927432700
> Hey @michael-o, according to [a previous
comment](https://github.com/apache/maven-surefire/pull/670#issuecomment-1863815281)
it seems that the intention of @NissMoony was to prov
zabetak commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1926867704
Hey @michael-o, according to [a previous
comment](https://github.com/apache/maven-surefire/pull/670#issuecomment-1863815281)
it seems that the intention of @NissMoony was to provide
michael-o commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1868376997
I have now re-read the code and your change. I fail to see how this change
only applies to successful tests. It applies to *all* type of results:
`SUCCESS` and non-`SUCCESS` otherw
michael-o commented on code in PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#discussion_r1434046528
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -679,6 +679,16 @@ public abstract class AbstractSurefire
michael-o commented on code in PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#discussion_r1434008789
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java:
##
@@ -679,6 +679,16 @@ public abstract class AbstractSurefire
michael-o commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1866161097
> > Please let me know whether you want to be merged.
>
> Yes, the problem really important fo our project. Sorry for long response,
not much time in the end of year. I'll fi
kriegaex commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1863878024
> what behaviour do you think is required as part of the plugin: the ability
to disable output for all tests (as in this PR, my cases) or for successful
tests only (as initially ask
NissMoony commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1863815281
> Please let me know whether you want to be merged.
Yes, the problem really important fo our project. Sorry for long response,
not much time in the end of year. I'll fix rema
kriegaex commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1859378299
OK, I quickly looked at the code. This PR does nothing of the sort I was
talking about above. It does not change stdOut/stdErr capturing in any way,
just adds a switch adding the ou
kriegaex commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1859364057
> Also, were can I see that this applies to passed tests only?
Yes, it seems that the `TestOutElements` classes need one negative test case
each, too.
@NissMoony, I gue
michael-o commented on PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#issuecomment-1838668154
Also, were can I see that this applies to passed tests only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
michael-o commented on code in PR #670:
URL: https://github.com/apache/maven-surefire/pull/670#discussion_r1413880902
##
surefire-its/src/test/resources/surefire-1934-enable-out-elements/pom.xml:
##
@@ -0,0 +1,64 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://w
16 matches
Mail list logo
