Re: [PR] Drop banner name [maven-parent]

2024-07-03 Thread via GitHub
michael-o commented on PR #180: URL: https://github.com/apache/maven-parent/pull/180#issuecomment-2205931260 Superseded by #191. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Drop banner name [maven-parent]

2024-07-03 Thread via GitHub
michael-o closed pull request #180: Drop banner name URL: https://github.com/apache/maven-parent/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] Drop banner name [maven-parent]

2024-06-08 Thread via GitHub
michael-o commented on PR #180: URL: https://github.com/apache/maven-parent/pull/180#issuecomment-2156083689 > @michael-o is it ready? Let me finish Surefire and Maven Dependency Plugin then I will get back to this and refresh my memory. -- This is an automated message from the Apa

Re: [PR] Drop banner name [maven-parent]

2024-06-08 Thread via GitHub
slawekjaranowski commented on PR #180: URL: https://github.com/apache/maven-parent/pull/180#issuecomment-2156074649 @michael-o is it ready? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Drop banner name [maven-parent]

2024-05-12 Thread via GitHub
michael-o commented on code in PR #180: URL: https://github.com/apache/maven-parent/pull/180#discussion_r1597606337 ## src/site/site.xml: ## @@ -23,7 +23,6 @@ under the License. xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.1 https://maven.apache.org/xsd/

Re: [PR] Drop banner name [maven-parent]

2024-05-12 Thread via GitHub
michael-o commented on PR #180: URL: https://github.com/apache/maven-parent/pull/180#issuecomment-2106197890 > And should we also change in: > > https://github.com/apache/maven-parent/blob/c6750dfc7a8aa7161d0afd56550ab79965b331e9/docs/src/site/site.xml#L26-L30 Good catch! --

Re: [PR] Drop banner name [maven-parent]

2024-05-12 Thread via GitHub
slawekjaranowski commented on PR #180: URL: https://github.com/apache/maven-parent/pull/180#issuecomment-2106196425 And should we also change in: https://github.com/apache/maven-parent/blob/c6750dfc7a8aa7161d0afd56550ab79965b331e9/docs/src/site/site.xml#L27 -- This is an automated

Re: [PR] Drop banner name [maven-parent]

2024-05-12 Thread via GitHub
slawekjaranowski commented on code in PR #180: URL: https://github.com/apache/maven-parent/pull/180#discussion_r1597604977 ## src/site/site.xml: ## @@ -23,7 +23,6 @@ under the License. xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.1 https://maven.apache.o

[PR] Drop banner name [maven-parent]

2024-05-12 Thread via GitHub
michael-o opened a new pull request, #180: URL: https://github.com/apache/maven-parent/pull/180 We don't need a banner name since we use an image as a banner. Both we be displayed side-by-side with Maven Fluido Skin 2.0.0. If the banner image needs an alternative text, the new Site Model do