gnodet closed pull request #1302: Improve transfer listener speed
URL: https://github.com/apache/maven/pull/1302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cstamas commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-1885605733
> Don't forget that we buy that we a lot of code complexity. The current
code is straight forward.
Agreed, it is straightforward, but may cause bottleneck (due concurrent
michael-o commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-188554
> With latest changes (trivial) perf tested locally both, this PR and #1371
>
> Slight improvement detected:
>
> * master: 1:12
>
> * both PRs: 1:09
>
>
cstamas commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-1885587088
With latest changes (trivial) perf tested locally both, this PR and
https://github.com/apache/maven/pull/1371
Slight improvement detected:
* master: 1:12
* both PRs: 1:09
gnodet commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-1884946363
> I think this is a good change despite no "speedup" sensed: the original
class uses `synchronized` on each listener method, meaning at one time only one
thread can enter only one method...
michael-o commented on code in PR #1302:
URL: https://github.com/apache/maven/pull/1302#discussion_r1447204050
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -34,79 +36,159 @@
*/
public class
gnodet commented on code in PR #1302:
URL: https://github.com/apache/maven/pull/1302#discussion_r1447093665
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -34,79 +36,159 @@
*/
public class ConsoleMavenTransferListener
michael-o commented on code in PR #1302:
URL: https://github.com/apache/maven/pull/1302#discussion_r1446105119
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -34,79 +36,159 @@
*/
public class
michael-o commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-1881105335
> I think this is a good change despite no "speedup" sensed: the original
class uses `synchronized` on each listener method, meaning at one time only one
thread can enter only one
cstamas commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-1881092448
I think this is a good change despite no "speedup" sensed: the original
class uses `synchronized` on each listener method, meaning at one time only one
thread can enter only one method...
michael-o commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-1880955503
Can you quatify the speed improvement in percent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cstamas commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-1804884501
+1 but no change detected...
built master with master vs this PR, pretty much same result (build time)
--
This is an automated message from the Apache Git Service.
To respond to the
gnodet opened a new pull request, #1302:
URL: https://github.com/apache/maven/pull/1302
- Try to improve concurrency
- Delegate display to a single thread
- Disable test which is broken with new logic
--
This is an automated message from the Apache Git Service.
To respond to the
13 matches
Mail list logo
