judovana commented on PR #26:
URL: https://github.com/apache/maven-archetypes/pull/26#issuecomment-1875354256
tyvm sir!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
elharo merged PR #26:
URL: https://github.com/apache/maven-archetypes/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
judovana commented on PR #26:
URL: https://github.com/apache/maven-archetypes/pull/26#issuecomment-1874990305
rebased to master at
https://github.com/apache/maven-archetypes/commit/a0f0e9ad1937caed9dedd9b2bbd3c1782b1fa2c1
, to see ti against all jdk8-21 tests.
--
This is an automated
judovana commented on code in PR #26:
URL: https://github.com/apache/maven-archetypes/pull/26#discussion_r1440165609
##
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
##
@@ -1,11 +1,11 @@
-#macro( compilerProperties $javaCompilerVersion )
judovana commented on code in PR #26:
URL: https://github.com/apache/maven-archetypes/pull/26#discussion_r1440165609
##
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
##
@@ -1,11 +1,11 @@
-#macro( compilerProperties $javaCompilerVersion )
elharo commented on code in PR #26:
URL: https://github.com/apache/maven-archetypes/pull/26#discussion_r1439707296
##
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
##
@@ -1,11 +1,11 @@
-#macro( compilerProperties $javaCompilerVersion )
judovana opened a new pull request, #26:
URL: https://github.com/apache/maven-archetypes/pull/26
There is macro which is using parameter and its local occurrence of same
name as is global property, thus shadow it. This PR is renaming it so it is
unique or at least distinguishable (second
