gnodet merged PR #1662:
URL: https://github.com/apache/maven/pull/1662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
carlspring commented on code in PR #1662:
URL: https://github.com/apache/maven/pull/1662#discussion_r1727515210
##
api/maven-api-core/src/main/java/org/apache/maven/api/ArtifactCoordinate.java:
##
@@ -23,64 +23,70 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- * T
gnodet closed pull request #1640: Renaming of `ArtifactCoordinate.getVersion()`
+ documentation
URL: https://github.com/apache/maven/pull/1640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gnodet commented on PR #1662:
URL: https://github.com/apache/maven/pull/1662#issuecomment-2304515823
Supersedes #1640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
desruisseaux commented on PR #1640:
URL: https://github.com/apache/maven/pull/1640#issuecomment-2294933659
Thanks, it looks good to me. We may need to revisit #1625 after this pull
request is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
gnodet commented on PR #1640:
URL: https://github.com/apache/maven/pull/1640#issuecomment-2294924267
@desruisseaux I've added follow-on commits at
https://github.com/gnodet/maven/tree/refactor/getVersionConstraint, containing
a proposal to add `ResolvedArtifact`, `ResolvedDependency` and
`
desruisseaux commented on code in PR #1640:
URL: https://github.com/apache/maven/pull/1640#discussion_r1719628286
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -23,76 +23,83 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- * An artifa
gnodet commented on code in PR #1640:
URL: https://github.com/apache/maven/pull/1640#discussion_r1719600158
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -23,76 +23,83 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- * An artifact poi
desruisseaux commented on PR #1640:
URL: https://github.com/apache/maven/pull/1640#issuecomment-2285909084
Added a commit trying to resolve the comments to the best of my
understanding. Did à `git push --force` for resolving conflicts.
--
This is an automated message from the Apache Git S
desruisseaux commented on code in PR #1640:
URL: https://github.com/apache/maven/pull/1640#discussion_r1715015611
##
api/maven-api-core/src/main/java/org/apache/maven/api/ArtifactCoordinate.java:
##
@@ -23,64 +23,68 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- *
desruisseaux commented on code in PR #1640:
URL: https://github.com/apache/maven/pull/1640#discussion_r1714939751
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -23,76 +23,83 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- * An artifa
desruisseaux commented on code in PR #1640:
URL: https://github.com/apache/maven/pull/1640#discussion_r1714920456
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -23,76 +23,83 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- * An artifa
desruisseaux commented on code in PR #1640:
URL: https://github.com/apache/maven/pull/1640#discussion_r1714911250
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -23,76 +23,83 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- * An artifa
desruisseaux commented on code in PR #1640:
URL: https://github.com/apache/maven/pull/1640#discussion_r1714881957
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -23,76 +23,83 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- * An artifa
gnodet commented on PR #1640:
URL: https://github.com/apache/maven/pull/1640#issuecomment-2283554760
@desruisseaux One possibility would be to split this PR. Keep this one for
the doc, and create another one for the getVersionConstraint() method if that
allows you to go further.
--
This
gnodet commented on code in PR #1640:
URL: https://github.com/apache/maven/pull/1640#discussion_r1713056325
##
api/maven-api-core/src/main/java/org/apache/maven/api/Artifact.java:
##
@@ -23,76 +23,83 @@
import org.apache.maven.api.annotations.Nonnull;
/**
- * An artifact poi
desruisseaux opened a new pull request, #1640:
URL: https://github.com/apache/maven/pull/1640
The pull request contains two changes:
* Documentation on `Artifact`, `ArtifactCoordinate`, `Dependency` and
`DependencyCoordinate`.
* Renaming of `ArtifactCoordinate.getVersion()` as `get
17 matches
Mail list logo
