Re: [PR] Simplify condition for nested output/error elements [maven-surefire]

2023-12-21 Thread via GitHub
michael-o commented on PR #702: URL: https://github.com/apache/maven-surefire/pull/702#issuecomment-1866513254 @kriegaex Have a look at this one as well. I am not happy that `stackTrace` is under this variable as well, but maybe just because it is internal (not public) it does not matter mu

Re: [PR] Simplify condition for nested output/error elements [maven-surefire]

2023-12-21 Thread via GitHub
michael-o commented on PR #702: URL: https://github.com/apache/maven-surefire/pull/702#issuecomment-1866370380 I believe that this one is incomplete and requires a full ticket with a fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Simplify condition for nested output/error elements [maven-surefire]

2023-12-21 Thread via GitHub
michael-o commented on PR #702: URL: https://github.com/apache/maven-surefire/pull/702#issuecomment-1866163515 @NissMoony have a look. A precluding simplification to your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Simplify condition for nested output/error elements [maven-surefire]

2023-12-21 Thread via GitHub
michael-o opened a new pull request, #702: URL: https://github.com/apache/maven-surefire/pull/702 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed