Re: [PR] Support building on JDK 21 [maven]

2023-10-16 Thread via GitHub
gnodet commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1360412280 ## .github/workflows/maven.yml: ## @@ -42,7 +42,7 @@ jobs: - uses: actions/setup-java@v3 with: - java-version: 8 + java-version: 11 Re

Re: [PR] Support building on JDK 21 [maven]

2023-10-15 Thread via GitHub
mthmulders commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1359916361 ## pom.xml: ## @@ -642,6 +679,26 @@ under the License. true + +enforce-bytecode-version Review Comment:

Re: [PR] Support building on JDK 21 [maven]

2023-10-15 Thread via GitHub
gnodet commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1359908557 ## pom.xml: ## @@ -642,6 +679,26 @@ under the License. true + +enforce-bytecode-version Review Comment:

Re: [PR] Support building on JDK 21 [maven]

2023-10-15 Thread via GitHub
gnodet commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1359907409 ## maven-model-builder/src/test/java/org/apache/maven/model/building/BuildModelSourceTransformerTest.java: ## @@ -136,6 +137,10 @@ public static boolean equalsDeep(Object

Re: [PR] Support building on JDK 21 [maven]

2023-10-15 Thread via GitHub
rmannibucau commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1359869569 ## maven-model-builder/src/test/java/org/apache/maven/model/building/BuildModelSourceTransformerTest.java: ## @@ -136,6 +137,10 @@ public static boolean equalsDeep(Ob

Re: [PR] Support building on JDK 21 [maven]

2023-10-15 Thread via GitHub
mthmulders commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1359866938 ## pom.xml: ## @@ -642,6 +679,26 @@ under the License. true + +enforce-bytecode-version Review Comment:

Re: [PR] Support building on JDK 21 [maven]

2023-10-15 Thread via GitHub
mthmulders commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1359866695 ## maven-model-builder/src/test/java/org/apache/maven/model/building/BuildModelSourceTransformerTest.java: ## @@ -136,6 +137,10 @@ public static boolean equalsDeep(Obj

Re: [PR] Support building on JDK 21 [maven]

2023-10-15 Thread via GitHub
mthmulders commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1359866633 ## .github/workflows/maven.yml: ## @@ -42,7 +42,7 @@ jobs: - uses: actions/setup-java@v3 with: - java-version: 8 + java-version: 11

Re: [PR] Support building on JDK 21 [maven]

2023-10-13 Thread via GitHub
mthmulders commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1358235045 ## .github/workflows/maven.yml: ## @@ -61,7 +61,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest, macOS-latest] -java: [8,

Re: [PR] Support building on JDK 21 [maven]

2023-10-13 Thread via GitHub
gnodet commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1358213669 ## .github/workflows/maven.yml: ## @@ -61,7 +61,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest, macOS-latest] -java: [8, 11,

Re: [PR] Support building on JDK 21 [maven]

2023-10-13 Thread via GitHub
mthmulders commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1358179630 ## .github/workflows/maven.yml: ## @@ -61,7 +61,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest, macOS-latest] -java: [8,

Re: [PR] Support building on JDK 21 [maven]

2023-10-13 Thread via GitHub
gnodet commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1358175935 ## .github/workflows/maven.yml: ## @@ -61,7 +61,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest, macOS-latest] -java: [8, 11,

Re: [PR] Support building on JDK 21 [maven]

2023-10-13 Thread via GitHub
mthmulders commented on code in PR #1278: URL: https://github.com/apache/maven/pull/1278#discussion_r1358171829 ## .github/workflows/maven.yml: ## @@ -61,7 +61,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest, macOS-latest] -java: [8,

[PR] Support building on JDK 21 [maven]

2023-10-13 Thread via GitHub
gnodet opened a new pull request, #1278: URL: https://github.com/apache/maven/pull/1278 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: