[
https://issues.apache.org/jira/browse/MNG-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-5579.
-------------------------------
Resolution: Fixed
Fixed with
[6c4627bd463dc080cb00c01a27b4ff830cbd5702|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=6c4627bd463dc080cb00c01a27b4ff830cbd5702].
> Unify error output/check logic from shell and batch scripts
> -----------------------------------------------------------
>
> Key: MNG-5579
> URL: https://issues.apache.org/jira/browse/MNG-5579
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
> Affects Versions: 3.1.1
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Minor
> Fix For: 3.4.0
>
>
> Currently,
> both output two different messages.
> Shell:
> {quote}
> Error: JAVA_HOME is not defined correctly.
> We cannot execute $JAVACMD
> {quote}
> while batch says:
> {quote}
> Error: JAVA_HOME not found in your environment.
> Please set the JAVA_HOME variable in your environment to match the
> location of your Java installation.
> {quote}
> Same applies for {{M2_HOME}}. Additionally, testing for the Java command is
> handled different in both scripts. The batch script relies on JAVA_HOME while
> the shell script can ignore it. Both should require {{JAVA_HOME}} or warn
> about and use {{which java}}, respectively {{java}} in {{PATH}} ({{for %%X
> in (java.exe) do (set JAVACMD=%%~$PATH:X)}}) on Windows. After that should
> proceed to checking {{M2_HOME}}.
> Any thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
