[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755585#comment-17755585
]
Konrad Windszus edited comment on MRELEASE-1109 at 8/17/23 2:47 PM:
--------------------------------------------------------------------
The logic for rewriting the version at
https://github.com/apache/maven-release/blob/0fae89df9706788902a1bc65d67cdbfae5f0d1b7/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#L443
needs to be extended to treat ci-friendly ones specially like it is currently
done in
https://github.com/eclipse-tycho/tycho/blob/2fcedecf38bf6244b911d486a6d8abd8c19ce5d8/tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/manipulation/PomManipulator.java#L88
was (Author: kwin):
The logic for rewriting the version at
https://github.com/apache/maven-release/blob/0fae89df9706788902a1bc65d67cdbfae5f0d1b7/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#L467
needs to be extended to treat ci-friendly ones specially like it is currently
done in
https://github.com/eclipse-tycho/tycho/blob/2fcedecf38bf6244b911d486a6d8abd8c19ce5d8/tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/manipulation/PomManipulator.java#L88
> update-versions removes the CI-friendly ${revisions}
> ----------------------------------------------------
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: update-versions
> Affects Versions: 2.5.3, 3.0.0-M7
> Reporter: Marcel Stör
> Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> <version>${revision}</version>
> ...
> <properties>
> <revision>1.0.0-SNAPSHOT</revision>
> </properties>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{<version>${revision}</version>}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
