[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2020-03-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069651#comment-17069651 ] Hudson commented on MNG-6105: - Build failed in Jenkins: Maven TLP » maven-studies » maven-metri

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2017-01-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15844047#comment-15844047 ] Hudson commented on MNG-6105: - SUCCESS: Integrated in Jenkins build maven-3.x #1519 (See [https

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-12-18 Thread Falko Modler (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15758981#comment-15758981 ] Falko Modler commented on MNG-6105: --- Sorry for not replying. I did not have the time to te

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-12-17 Thread JIRA
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15757725#comment-15757725 ] Guillaume Boué commented on MNG-6105: - All right, the issue is fixed to me yes. > prope

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-12-17 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15757716#comment-15757716 ] Michael Osipov commented on MNG-6105: - Guillaume, if you consider it fixed and the OP ha

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-16 Thread JIRA
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15580018#comment-15580018 ] Guillaume Boué commented on MNG-6105: - Can you test with the latest snapshot of {{maven-

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-15 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578964#comment-15578964 ] Hudson commented on MNG-6105: - SUCCESS: Integrated in Jenkins build maven-3.x #1398 (See [https

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-15 Thread Christian Schulte (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578777#comment-15578777 ] Christian Schulte commented on MNG-6105: Should work as well. You need to change the

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-15 Thread JIRA
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578354#comment-15578354 ] Guillaume Boué commented on MNG-6105: - All methods of {{Properties}} itself (and {{Hasht

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-15 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578343#comment-15578343 ] Michael Osipov commented on MNG-6105: - This would only work, imho, if someone else synch

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-15 Thread JIRA
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578189#comment-15578189 ] Guillaume Boué commented on MNG-6105: - So the issue is about copying one Properties to a

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread Christian Schulte (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15577210#comment-15577210 ] Christian Schulte commented on MNG-6105: Something to provide via 'maven-shared-util

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread JIRA
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576930#comment-15576930 ] Guillaume Boué commented on MNG-6105: - Interesting indeed, hadn't thought of that. I th

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread Christian Schulte (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576795#comment-15576795 ] Christian Schulte commented on MNG-6105: I'd do it that way: {code} package org.apa

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576751#comment-15576751 ] Michael Osipov commented on MNG-6105: - Very interesting approach. ~gboue, what do you th

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576748#comment-15576748 ] Michael Osipov commented on MNG-6105: - Very interesting approach. ~gboue, what do you th

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread Christian Schulte (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576722#comment-15576722 ] Christian Schulte commented on MNG-6105: We've had a similar problem in the 'maven-a

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread Falko Modler (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576647#comment-15576647 ] Falko Modler commented on MNG-6105: --- I still don't know what is removing system properties

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575889#comment-15575889 ] Michael Osipov commented on MNG-6105: - Right, though I am confused who is actually remov

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread JIRA
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575851#comment-15575851 ] Guillaume Boué commented on MNG-6105: - {{synchronized}} on the static method would lock

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-14 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575061#comment-15575061 ] Michael Osipov commented on MNG-6105: - Why not use {{synchronized}} to have an idiot-pro

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573330#comment-15573330 ] Hudson commented on MNG-6105: - SUCCESS: Integrated in Jenkins build maven-3.x #1394 (See [https

[jira] [Commented] (MNG-6105) properties.internal.SystemProperties.addSystemProperties() is not really thread-safe

2016-10-13 Thread JIRA
[ https://issues.apache.org/jira/browse/MNG-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573288#comment-15573288 ] Guillaume Boué commented on MNG-6105: - I would prefer not to use {{clone()}} here, addin