[ 
https://issues.apache.org/jira/browse/MNG-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423545#comment-17423545
 ] 

Joseph Walton commented on MNG-6898:
------------------------------------

Thanks for fixing this, [~cstamas]; having one file left unconverted to JSR 330 
was annoying.

> Convert DefaultLifecyclePluginAnalyzer to JSR 330
> -------------------------------------------------
>
>                 Key: MNG-6898
>                 URL: https://issues.apache.org/jira/browse/MNG-6898
>             Project: Maven
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 3.6.3
>            Reporter: Joseph Walton
>            Assignee: Tamás Cservenák
>            Priority: Major
>             Fix For: 4.0.x-candidate, 4.0.0-alpha-1
>
>
> Convert {{DefaultLifecyclePluginAnalyzer}} in {{maven-core}} to JSR 330 
> annotations. This follows on from MNG-5577, which converted the other classes.
> The complication here is that, with the annotations changed, the 
> {{lifecycleMappings}} {{Map}} is no longer getting filtered by sisu.plexus's 
> {{RealmFilteredBeans}}. That means extensions added in one module will appear 
> in all of them, which makes 
> [{{MavenITmng4385LifecycleMappingFromExtensionInReactorTest}}|https://github.com/apache/maven-integration-testing/blob/6e480ac3a436bf4f3624f36935578966430c654c/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4385LifecycleMappingFromExtensionInReactorTest.java]
>  fail.
> From what I can see, the only place a {{RealmFilteredBeans}} is used during 
> injection is when the resource is located through 
> {{DefaultPlexusBeanLocator}}. However, that's not the case after that field 
> switches from {{@Requirement}} to {{@Inject}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to